Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unneed tasks & Check protoc generated contents #53

Merged
merged 24 commits into from
Aug 24, 2024

Conversation

rerost
Copy link
Owner

@rerost rerost commented Aug 22, 2024

use https://github.com/arduino/setup-protoc

  • generate pb files automaticaly

@rerost rerost changed the title Drop unneed tasks Drop unneed tasks & Check protoc generated contents Aug 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 43.10345% with 33 lines in your changes missing coverage. Please review.

Project coverage is 53.98%. Comparing base (693b86a) to head (9124578).

Files Patch % Lines
e2etest/dummyserver/echo_grpc.pb.go 31.03% 19 Missing and 1 partial ⚠️
rerost/giro/hosts_grpc.pb.go 55.17% 11 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   53.82%   53.98%   +0.16%     
==========================================
  Files          13       15       +2     
  Lines         981      991      +10     
==========================================
+ Hits          528      535       +7     
- Misses        390      393       +3     
  Partials       63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rerost rerost merged commit 8fc65ea into master Aug 24, 2024
4 checks passed
@rerost rerost deleted the rerost/check-protoc-in-ci branch August 24, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants